deps: bump Go version in Dockerfiles #8522
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8522 +/- ##
==========================================
+ Coverage 81.82% 81.83% +0.01%
==========================================
Files 413 412 -1
Lines 40518 40518
==========================================
+ Hits 33153 33159 +6
+ Misses 5989 5962 -27
- Partials 1376 1397 +21 🚀 New features to boost your workflow:
|
|
It looks like we've also broken the PSM interop tests. @stanley-cheung, could you please bump the Go version to Go 1.25 on all the Dockerfiles? This would give us more time before we need to update the version again. Reference PR: https://github.com/grpc/grpc-go/pull/7629/files |
arjan-bal
added
Area: Testing
Done. Thanks for the reference. |
interop/observability/Dockerfile
Outdated
| @@ -17,7 +17,7 @@ | |||
| # Stage 1: Build the interop test client and server | |||
| # | |||
|
|
|||
| FROM golang:1.23-bullseye as build | |||
| FROM golang:1.25-bullseye as build | |||
There was a problem hiding this comment.
It looks like golang:1.25-bullseye is not published yet.
$ docker pull golang:1.25-bullseye
Error response from daemon: manifest for golang:1.25-bullseye not found: manifest unknown: manifest unknown
$ docker pull golang:1.24-bullseye
1.24-bullseye: Pulling from library/golang
078965fc7cf3: Pull complete
8620e616831b: Pull complete
99bdf4e3059e: Pull complete
79e3925f0bdb: Pull complete
9a940d118df6: Pull complete
25ac2e409764: Pull complete
4f4fb700ef54: Pull complete
Digest: sha256:2cdc80dc25edcb96ada1654f73092f2928045d037581fa4aa7c40d18af7dd85a
Status: Downloaded newer image for golang:1.24-bullseye
docker.io/library/golang:1.24-bullseyeWe can use golang:1.25-alpine here also. I tried building with the alpine image and it worked.
TAG_NAME="gcr.io/a/b"
docker build --no-cache -t ${TAG_NAME} -f ./interop/observability/Dockerfile .There was a problem hiding this comment.
Fixed thanks.
There was a problem hiding this comment.
I just realized that this Dockerfile is using bullseye because the entrypoint is a bash script. Since alpine images don't have Bash, we'll need to use golang:1.24-bullseye instead. My apologies for the incorrect suggestion
There was a problem hiding this comment.
No problem. I had the tinkering something was off - you got it right.
arjan-bal
changed the title
|
Can confirm that the grpc observability test are back to passing after this fix. Thanks |
#8509 (e847f29#diff-ec20ea664a5618c21b884b2b3845c9e8bd35c303456b92527be9d004529eb138) broke the observability tests (https://fusion2.corp.google.com/ci/kokoro/prod:grpc-gcp%2Ftools%2Fobservability%2Fmaster%2Fcontinuous_go/activity/94077d7d-4594-4509-abd8-73f967fb41ba/log)
This should fix it.
RELEASE NOTES: N/A